Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump stack.yaml, include in sdist file #520

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Bump stack.yaml, include in sdist file #520

merged 1 commit into from
Oct 15, 2023

Conversation

mpilgrem
Copy link
Contributor

stack.yaml is bumped to GHC 9.4.7, the most recent version of GHC supported by the tool.

stack.yaml is incuded in the sdist file. This will help Stack users install the tool from Hackage.

(As an aside, the current stack.yaml file will not work because it does not set the flags required for its mintty dependency. That falls away if this pull request is adopted.)

@tomjaguarpaw
Copy link
Collaborator

Thanks! Any idea how to address this build failure?

https://github.com/kowainik/stan/actions/runs/6518739825/job/17704572148?pr=520

Maybe the version of stack in ci.yml needs to be bumped?

@mpilgrem
Copy link
Contributor Author

Sorry, I had forgotten about the test-suite. Trying again.

@mpilgrem
Bump stack.yaml, include in sdist file
3782964 
stack.yaml is bumped to GHC 9.4.7, the most recent version of GHC supported by the tool.

stack.yaml is incuded in the sdist file. This will help Stack users install the tool from Hackage.
@tomjaguarpaw
Copy link
Collaborator

I'm confused how this managed to pass given that it doesn't contain a change to ci.yml. Do you understand?

@mpilgrem
Copy link
Contributor Author

@tomjaguarpaw, it was failing before because the test-suite (a) required hedgehog < 1.2 (while lts-21.15 specified hedgehog-1.2); and (b) hedgehog-1.1.2 required primitive < 0.8 (while lts-21.15 specified primitive-0.8.0.0. Downgrading those dependencies (as extra-deps) solved the problem.

@tomjaguarpaw
Copy link
Collaborator

OK, thanks. If you'd be willing to be the "owner" of stan's stack support then I would appreciate it. I have no idea about stack.

@tomjaguarpaw tomjaguarpaw merged commit 03e1f59 into kowainik:main Oct 15, 2023
33 checks passed
@mpilgrem
Copy link
Contributor Author

I'm happy to keep a weather eye on building Stan with Stack. The Stack project was experimenting with using Stan as part of its CI, until Stack moved on to a version of GHC that Stan did not support. I'm currently looking at doing so again, as Stack is still built with GHC 9.4.7 (for now).

@tomjaguarpaw
Copy link
Collaborator

Great, feel free to ping me if you need help with stan support for any Stack version. 9.6 support is imminent.

@mpilgrem mpilgrem deleted the stack branch October 15, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjaguarpaw tomjaguarpaw tomjaguarpaw approved these changes

@vrom911 vrom911 Awaiting requested review from vrom911 vrom911 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpilgrem @tomjaguarpaw